zhannngchen commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1853185227
##########
be/src/olap/base_tablet.h:
##########
@@ -236,10 +239,21 @@ class BaseTablet {
static Status update_delete_bitmap(const BaseTabletSPtr& self,
TabletTxnInfo* txn_info,
int64_t txn_id, int64_t txn_expiration
= 0);
+ // The {invisible_rowsets} and {base_txn_id} is set in transaction load.
In transaction load:
+ // * the {txn_id} is sub_txn_id
+ // * the {invisible_rowsets} is used to calculate delete bitmap
+ // * the {base_txn_id} is used as lock id in cloud mode
+ // * the {next_visible_version} is the next version of the partition
visible version
+ static Status update_delete_bitmap(const BaseTabletSPtr& self,
TabletTxnInfo* txn_info,
+ int64_t txn_id, int64_t txn_expiration,
+ std::vector<RowsetSharedPtr>*
invisible_rowsets,
+ int64_t base_txn_id, int64_t
next_visible_version,
Review Comment:
change `base_txn_id` to `lock_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
