cambyzju commented on code in PR #9581:
URL: https://github.com/apache/incubator-doris/pull/9581#discussion_r873294774
##########
be/src/runtime/memory/chunk_allocator.cpp:
##########
@@ -219,6 +224,10 @@ void ChunkAllocator::free(const Chunk& chunk, MemTracker*
tracker) {
}
} while (!_reserved_bytes.compare_exchange_weak(old_reserved_bytes,
new_reserved_bytes));
+ // Reduce set metric frequency
+ if (_reserved_bytes % 100 == 32) {
Review Comment:
How to make sure the correctness?
At the first look, (_reserved_bytes % 100 < 32) or (_reserved_bytes % 100 >
32) both will not update the metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
