morrySnow commented on code in PR #44023:
URL: https://github.com/apache/doris/pull/44023#discussion_r1848198909
##########
regression-test/data/nereids_hint_tpcds_p0/shape/query13.out:
##########
@@ -18,10 +18,9 @@ PhysicalResultSink
------------------------PhysicalProject
--------------------------hashJoin[INNER_JOIN broadcast]
hashCondition=((store_sales.ss_addr_sk = customer_address.ca_address_sk))
otherCondition=((((ca_state IN ('IL', 'TN', 'TX') AND
((store_sales.ss_net_profit >= 100.00) AND (store_sales.ss_net_profit <=
200.00))) OR (ca_state IN ('ID', 'OH', 'WY') AND ((store_sales.ss_net_profit >=
150.00) AND (store_sales.ss_net_profit <= 300.00)))) OR (ca_state IN ('IA',
'MS', 'SC') AND ((store_sales.ss_net_profit >= 50.00) AND
(store_sales.ss_net_profit <= 250.00))))) build RFs:RF0
ca_address_sk->[ss_addr_sk]
----------------------------PhysicalProject
-------------------------------filter((store_sales.ss_net_profit <= 300.00) and
(store_sales.ss_net_profit >= 50.00) and (store_sales.ss_sales_price <= 200.00)
and (store_sales.ss_sales_price >= 50.00))
Review Comment:
lose a filter?
##########
regression-test/data/nereids_hint_tpcds_p0/shape/query13.out:
##########
@@ -18,10 +18,9 @@ PhysicalResultSink
------------------------PhysicalProject
--------------------------hashJoin[INNER_JOIN broadcast]
hashCondition=((store_sales.ss_addr_sk = customer_address.ca_address_sk))
otherCondition=((((ca_state IN ('IL', 'TN', 'TX') AND
((store_sales.ss_net_profit >= 100.00) AND (store_sales.ss_net_profit <=
200.00))) OR (ca_state IN ('ID', 'OH', 'WY') AND ((store_sales.ss_net_profit >=
150.00) AND (store_sales.ss_net_profit <= 300.00)))) OR (ca_state IN ('IA',
'MS', 'SC') AND ((store_sales.ss_net_profit >= 50.00) AND
(store_sales.ss_net_profit <= 250.00))))) build RFs:RF0
ca_address_sk->[ss_addr_sk]
----------------------------PhysicalProject
-------------------------------filter((store_sales.ss_net_profit <= 300.00) and
(store_sales.ss_net_profit >= 50.00) and (store_sales.ss_sales_price <= 200.00)
and (store_sales.ss_sales_price >= 50.00))
---------------------------------PhysicalOlapScan[store_sales] apply RFs: RF0
RF1 RF2 RF4
+------------------------------PhysicalOlapScan[store_sales] apply RFs: RF0 RF1
RF2 RF4
----------------------------PhysicalProject
-------------------------------filter((customer_address.ca_country = 'United
States') and ca_state IN ('IA', 'ID', 'IL', 'MS', 'OH', 'SC', 'TN', 'TX', 'WY'))
+------------------------------filter(((((customer_address.ca_country = 'United
States') AND ca_state IN ('IL', 'TN', 'TX')) OR ((customer_address.ca_country =
'United States') AND ca_state IN ('ID', 'OH', 'WY'))) OR
((customer_address.ca_country = 'United States') AND ca_state IN ('IA', 'MS',
'SC'))) and (customer_address.ca_country = 'United States') and ca_state IN
('IA', 'ID', 'IL', 'MS', 'OH', 'SC', 'TN', 'TX', 'WY'))
Review Comment:
seem a worse filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
