github-actions[bot] commented on code in PR #44208:
URL: https://github.com/apache/doris/pull/44208#discussion_r1849965838
##########
be/src/pipeline/exec/join/process_hash_table_probe_impl.h:
##########
@@ -363,7 +356,7 @@ uint32_t
ProcessHashTableProbe<JoinOpType>::_process_probe_null_key(uint32_t pro
template <int JoinOpType>
template <bool with_other_conjuncts>
Status
ProcessHashTableProbe<JoinOpType>::do_mark_join_conjuncts(vectorized::Block*
output_block,
Review Comment:
warning: function 'do_mark_join_conjuncts' has cognitive complexity of 58
(threshold 50) [readability-function-cognitive-complexity]
```cpp
_conjuncts>
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:370:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
ck->rows();
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:382:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
= nullptr;
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:394:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
tched = -1;
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:396:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
xs[i] != 0;
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:397:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
are_join) {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:400:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:400:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:404:** +1,
nesting level increased to 5
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:409:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:413:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:413:** +1
```cpp
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:414:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
null_map) {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:419:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:419:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:419:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
} else {
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:426:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
ot nullable
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:431:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:435:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
ll = false;
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:435:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
ll = false;
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:441:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
ter.data();
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:460:** +1
```cpp
_has_null =
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:461:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
_conjuncts;
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:463:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
_indexs[i];
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:464:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
[i] == 0) {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:467:** +1
```cpp
[i] = true;
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:471:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:471:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
} else {
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:473:** +1,
nesting level increased to 3
```cpp
_indexs[i];
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:473:** +1
```cpp
_indexs[i];
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:480:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/pipeline/exec/join/process_hash_table_probe_impl.h:482:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
mark column
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
