zhannngchen commented on code in PR #44284:
URL: https://github.com/apache/doris/pull/44284#discussion_r1848295141
##########
be/src/olap/delete_bitmap_calculator.cpp:
##########
@@ -209,16 +211,18 @@ Status
MergeIndexDeleteBitmapCalculator::calculate_one(RowLocation& loc) {
}
Status MergeIndexDeleteBitmapCalculator::calculate_all(DeleteBitmapPtr
delete_bitmap) {
- RowLocation loc;
- while (true) {
- auto st = calculate_one(loc);
- if (st.is<ErrorCode::END_OF_FILE>()) {
- break;
+ RETURN_IF_CATCH_EXCEPTION({
Review Comment:
you should consider to process the exception for method
`MergeIndexDeleteBitmapCalculator::init` as well.
`_heap->push(&_contexts.back());` might throw exception there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
