github-actions[bot] commented on code in PR #44098:
URL: https://github.com/apache/doris/pull/44098#discussion_r1846701820
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -476,7 +551,7 @@
}
Status ScalarColumnReader::read_column_data(ColumnPtr& doris_column,
DataTypePtr& type,
Review Comment:
warning: function 'read_column_data' has cognitive complexity of 81
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ScalarColumnReader::read_column_data(ColumnPtr& doris_column,
DataTypePtr& type,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:555:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_converter == nullptr) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:558:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (!_converter->support()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:567:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
do {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:568:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_chunk_reader->remaining_num_values() == 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:569:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (!_chunk_reader->has_next_page()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:574:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->next_page());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:574:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->next_page());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:576:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_nested_column) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:577:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data_idempotent());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:577:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data_idempotent());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:578:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_read_nested_column(resolved_column,
resolved_type, filter_map,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:578:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_read_nested_column(resolved_column,
resolved_type, filter_map,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:588:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (read_ranges.size() == 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:591:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_page());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:591:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_page());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:593:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:597:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (filter_map.has_filter() && filter_map.filter_ratio() > 0.6) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:597:** +1
```cpp
if (filter_map.has_filter() && filter_map.filter_ratio() > 0.6) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:603:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (batch_size >= remaining_num_values &&
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:603:** +1
```cpp
if (batch_size >= remaining_num_values &&
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:608:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_page());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:608:** +6,
including nesting penalty of 5, nesting level increased to 6
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_page());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:610:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
if (!_chunk_reader->has_next_page()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:615:** +1
```cpp
skip_whole_batch = batch_size <= remaining_num_values &&
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:617:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (skip_whole_batch) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:622:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data_idempotent());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:622:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data_idempotent());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:647:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_chunk_reader->remaining_num_values() == 0 &&
!_chunk_reader->has_next_page()) {
^
```
</details>
##########
be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:
##########
@@ -316,9 +319,15 @@ Status ScalarColumnReader::_read_values(size_t num_values,
ColumnPtr& doris_colu
* whether the reader should read the remaining value of the last row in
previous page.
*/
Status ScalarColumnReader::_read_nested_column(ColumnPtr& doris_column,
DataTypePtr& type,
Review Comment:
warning: function '_read_nested_column' has cognitive complexity of 119
(threshold 50) [readability-function-cognitive-complexity]
```cpp
Status ScalarColumnReader::_read_nested_column(ColumnPtr& doris_column,
DataTypePtr& type,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:331:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (align_rows) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:336:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:345:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (has_rep_level) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:347:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
while (parsed_rows <= batch_size && remaining_values > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:347:** +1
```cpp
while (parsed_rows <= batch_size && remaining_values > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:349:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (rep_level == 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:350:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (parsed_rows == batch_size) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:360:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (filter_map.has_filter()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:364:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(filter_map.generate_nested_filter_map(
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:364:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(filter_map.generate_nested_filter_map(
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:369:** +1,
nesting level increased to 1
```cpp
} else if (!align_rows) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:379:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (has_def_level) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:381:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:388:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (doris_column->is_nullable()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:394:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:395:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_field_schema->is_nullable) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:408:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
while (has_read < origin_size + parsed_values) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:411:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
while (has_read < origin_size + parsed_values &&
_def_levels[has_read] == def_level) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:416:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (def_level < _field_schema->repeated_parent_def_level) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:422:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (is_null) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:424:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:428:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (prev_is_null == is_null && (USHRT_MAX - null_map.back() >=
loop_read)) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:428:** +1
```cpp
if (prev_is_null == is_null && (USHRT_MAX - null_map.back() >=
loop_read)) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:430:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:431:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (!(prev_is_null ^ is_null)) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:435:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
while (remaining > USHRT_MAX) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:447:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (current_filter_map->filter_all()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:448:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (null_size > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:449:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(null_size, false));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:449:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(null_size, false));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:451:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (nonnull_size > 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:452:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(nonnull_size, true));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:452:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(nonnull_size, true));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:454:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (ancestor_nulls != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:455:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(ancestor_nulls,
false));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:455:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(ancestor_nulls,
false));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:457:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:461:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:461:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:466:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:466:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:468:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (ancestor_nulls != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:469:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(ancestor_nulls,
false));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:469:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->skip_values(ancestor_nulls,
false));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:473:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (!align_rows) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:477:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_chunk_reader->remaining_num_values() == 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:478:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_chunk_reader->has_next_page()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:479:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->next_page());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:479:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->next_page());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:480:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:480:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_chunk_reader->load_page_data());
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:483:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:488:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (current_filter_map->has_filter()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:489:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (current_filter_map->filter_all()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:492:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.cpp:514:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_rep_levels.size() > 0) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
