github-actions[bot] commented on code in PR #44105:
URL: https://github.com/apache/doris/pull/44105#discussion_r1845748636
##########
be/src/http/http_client.h:
##########
@@ -147,7 +147,8 @@
size_t on_response_data(const void* data, size_t length);
private:
- const char* _to_errmsg(CURLcode code);
+ const char* _to_errmsg(CURLcode code) const;
+ const char* _get_url() const;
Review Comment:
warning: function '_get_url' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const char* _get_url() const;
```
##########
be/src/http/http_client.h:
##########
@@ -147,7 +147,8 @@ class HttpClient {
size_t on_response_data(const void* data, size_t length);
private:
- const char* _to_errmsg(CURLcode code);
+ const char* _to_errmsg(CURLcode code) const;
Review Comment:
warning: function '_to_errmsg' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] const char* _to_errmsg(CURLcode code) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
