gavinchou commented on code in PR #43525:
URL: https://github.com/apache/doris/pull/43525#discussion_r1845487058
##########
be/src/io/fs/local_file_system.h:
##########
@@ -34,6 +34,8 @@ class LocalFileSystem final : public FileSystem {
public:
~LocalFileSystem() override;
+ static Path convert_to_abs_path(const Path& path);
Review Comment:
add comment for this public static function. how does it behave
we have to emphasize that what is the path and what is the abs path.
what if the path is invalid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
