gavinchou commented on code in PR #44013:
URL: https://github.com/apache/doris/pull/44013#discussion_r1844208821
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -393,6 +393,9 @@ FileBlocks BlockFileCache::get_impl(const UInt128Wrapper&
hash, const CacheConte
auto& file_blocks = it->second;
DCHECK(!file_blocks.empty());
+ if (file_blocks.empty()) {
Review Comment:
should we remove the unexpected key?
and we have need to print some waring for this exceptional branch, e.g.,
hex(key), path and etc.
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -393,6 +393,9 @@ FileBlocks BlockFileCache::get_impl(const UInt128Wrapper&
hash, const CacheConte
auto& file_blocks = it->second;
DCHECK(!file_blocks.empty());
+ if (file_blocks.empty()) {
Review Comment:
should we remove the unexpected key?
and we need to print some waring for this exceptional branch, e.g.,
hex(key), path and etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
