zhangstar333 commented on code in PR #44029: URL: https://github.com/apache/doris/pull/44029#discussion_r1843391871
########## be/src/vec/core/block.cpp: ########## @@ -511,16 +511,13 @@ std::string Block::dump_data(size_t begin, size_t row_limit, bool allow_null_mis std::string s; if (data[i].column) { if (data[i].type->is_nullable() && !data[i].column->is_nullable()) { - if (is_column_const(*data[i].column)) { - s = data[i].to_string(0); - } else { - assert(allow_null_mismatch); - s = assert_cast<const DataTypeNullable*>(data[i].type.get()) - ->get_nested_type() - ->to_string(*data[i].column, row_num); - } + assert(allow_null_mismatch); Review Comment: type: column: nullable_string ----->const(NULLABLE(String)) string -----> const(NULLABLE(String)) string----> NULLABLE(STRING) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org