HappenLee commented on code in PR #43873: URL: https://github.com/apache/doris/pull/43873#discussion_r1842023312
########## be/src/vec/columns/column.h: ########## @@ -669,7 +669,7 @@ class IColumn : public COW<IColumn> { // only used in agg value replace // ColumnString should replace according to 0,1,2... ,size,0,1,2... virtual void replace_column_data(const IColumn&, size_t row, size_t self_row = 0) = 0; - + // replace data to default value if null, used to avoid null data output decimal check failure Review Comment: Add more detail comment for the two api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org