morrySnow commented on PR #9460:
URL: https://github.com/apache/incubator-doris/pull/9460#issuecomment-1123400741
> In fact, the following configuration is enough. `reviewdog` is not a
necessity. Because when met wrong checkstyle, `mvn checkstyle:check` also can
cause the ut failed.
>
> ```
> ---
> name: FE Code Style Checker
> on:
> pull_request:
> jobs:
> java-checkstyle:
> name: "CheckStyle"
> runs-on: ubuntu-latest
> steps:
> - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
> uses: actions/checkout@v2
> with:
> persist-credentials: false
> submodules: recursive
> - name: "Run java checkstyle"
> run:
> cd fe && mvn checkstyle:check
>
> ```
The final status is setting all check style rules' severity to 'error'.
Currently, we have too many original code that violate check style rules. We
need to fix all warnings caused by original codes and set Checker's severity to
'error' before we use `mvn checkstyle:check` instead of review dog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
