morningman commented on code in PR #43469:
URL: https://github.com/apache/doris/pull/43469#discussion_r1839621854
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -1040,7 +1178,8 @@ Status
NewJsonReader::_read_one_message(std::unique_ptr<uint8_t[]>* file_buf, si
}
// ---------SIMDJSON----------
// simdjson, replace none simdjson function if it is ready
-Status NewJsonReader::_simdjson_init_reader() {
+Status NewJsonReader::_simdjson_init_reader(bool is_load) {
+ _is_load = is_load;
Review Comment:
already set in `Status NewJsonReader::init_reader`.
And not need to pass it from function parameter
##########
be/src/vec/exec/format/json/new_json_reader.h:
##########
@@ -292,6 +296,18 @@ class NewJsonReader : public GenericReader {
std::unordered_map<std::string, std::string> _col_default_value_map;
int32_t skip_bitmap_col_idx {-1};
+
+ bool _is_load = true;
Review Comment:
Add comment in code to describe this field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
