github-actions[bot] commented on code in PR #43627:
URL: https://github.com/apache/doris/pull/43627#discussion_r1839669788
##########
be/src/runtime/runtime_filter_mgr.cpp:
##########
@@ -377,7 +380,8 @@ Status RuntimeFilterMgr::sync_filter_size(const
PSyncFilterSizeRequest* request)
}
// merge data
-Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest*
request,
+Status RuntimeFilterMergeControllerEntity::merge(std::weak_ptr<QueryContext>
query_ctx,
Review Comment:
warning: function 'merge' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status RuntimeFilterMergeControllerEntity::merge(std::weak_ptr<QueryContext>
query_ctx,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/runtime_filter_mgr.cpp:382:** 119 lines including
whitespace and comments (threshold 80)
```cpp
Status RuntimeFilterMergeControllerEntity::merge(std::weak_ptr<QueryContext>
query_ctx,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
