github-actions[bot] commented on code in PR #43628:
URL: https://github.com/apache/doris/pull/43628#discussion_r1837537280
##########
be/src/vec/runtime/vdata_stream_recvr.cpp:
##########
@@ -401,13 +401,13 @@ Status VDataStreamRecvr::create_merger(const
VExprContextSPtrs& ordering_expr,
return Status::OK();
}
-Status VDataStreamRecvr::add_block(const PBlock& pblock, int sender_id, int
be_number,
- int64_t packet_seq,
::google::protobuf::Closure** done,
+Status VDataStreamRecvr::add_block(const PBlock& pblock, int sender_id,
int64_t packet_seq,
Review Comment:
warning: method 'add_block' can be made const
[readability-make-member-function-const]
be/src/vec/runtime/vdata_stream_recvr.cpp:406:
```diff
- const uint64_t time_to_find_recvr) {
+ const uint64_t time_to_find_recvr)
const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
