github-actions[bot] commented on code in PR #43623:
URL: https://github.com/apache/doris/pull/43623#discussion_r1837428021


##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -227,8 +233,7 @@ PipelinePtr 
PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {
     return pipeline;
 }
 
-Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& 
request,
-                                        ThreadPool* thread_pool) {
+Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& 
request) {

Review Comment:
   warning: function 'prepare' exceeds recommended size/complexity thresholds 
[readability-function-size]
   ```cpp
   Status PipelineFragmentContext::prepare(const 
doris::TPipelineFragmentParams& request) {
                                   ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/pipeline/pipeline_fragment_context.cpp:235:** 124 lines including 
whitespace and comments (threshold 80)
   ```cpp
   Status PipelineFragmentContext::prepare(const 
doris::TPipelineFragmentParams& request) {
                                   ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to