yiguolei commented on code in PR #42006:
URL: https://github.com/apache/doris/pull/42006#discussion_r1836523503
##########
be/src/olap/olap_server.cpp:
##########
@@ -242,29 +242,60 @@ Status StorageEngine::start_bg_threads() {
auto single_replica_compaction_threads =
get_single_replica_compaction_threads_num(data_dirs.size());
- RETURN_IF_ERROR(ThreadPoolBuilder("BaseCompactionTaskThreadPool")
- .set_min_threads(base_compaction_threads)
- .set_max_threads(base_compaction_threads)
- .build(&_base_compaction_thread_pool));
- RETURN_IF_ERROR(ThreadPoolBuilder("CumuCompactionTaskThreadPool")
- .set_min_threads(cumu_compaction_threads)
- .set_max_threads(cumu_compaction_threads)
- .build(&_cumu_compaction_thread_pool));
- RETURN_IF_ERROR(ThreadPoolBuilder("SingleReplicaCompactionTaskThreadPool")
- .set_min_threads(single_replica_compaction_threads)
- .set_max_threads(single_replica_compaction_threads)
- .build(&_single_replica_compaction_thread_pool));
-
- if (config::enable_segcompaction) {
- RETURN_IF_ERROR(ThreadPoolBuilder("SegCompactionTaskThreadPool")
-
.set_min_threads(config::segcompaction_num_threads)
-
.set_max_threads(config::segcompaction_num_threads)
- .build(&_seg_compaction_thread_pool));
+ if (wg_sptr != nullptr) {
Review Comment:
我感觉else 没意义，我们当前不会为nullptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
