924060929 commented on code in PR #43516: URL: https://github.com/apache/doris/pull/43516#discussion_r1835335349
########## fe/fe-common/src/main/java/org/apache/doris/common/GZIPUtils.java: ########## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.common; + +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.util.zip.GZIPInputStream; +import java.util.zip.GZIPOutputStream; + +public class GZIPUtils { + public static boolean isGZIPCompressed(byte[] data) { + // From RFC 1952: 3.2. Members with a deflate compressed data stream (ID1 = 8, ID2 = 8) + return data.length >= 2 && data[0] == (byte) 0x1F && data[1] == (byte) 0x8B; + } + + public static byte[] compress(byte[] data) throws IOException { + ByteArrayOutputStream bytesStream = new ByteArrayOutputStream(); + try (GZIPOutputStream gzipStream = new GZIPOutputStream(bytesStream)) { + gzipStream.write(data); + } + return bytesStream.toByteArray(); + } + + public static byte[] decompress(byte[] data) throws IOException { + ByteArrayInputStream bytesStream = new ByteArrayInputStream(data); + try (GZIPInputStream gzipStream = new GZIPInputStream(bytesStream)) { + return gzipStream.readAllBytes(); + } + } Review Comment: This grammar not support java8. I think you should change to ```java import org.apache.commons.io.IOUtils; public static byte[] decompress(byte[] data) throws IOException { ByteArrayInputStream bytesStream = new ByteArrayInputStream(data); try (GZIPInputStream gzipStream = new GZIPInputStream(bytesStream)) { return IOUtils.toByteArray(gzipStream); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
