HappenLee commented on code in PR #9170:
URL: https://github.com/apache/incubator-doris/pull/9170#discussion_r867301048
##########
be/src/vec/functions/array/function_array_element.h:
##########
@@ -181,7 +183,8 @@ class FunctionArrayElement : public IFunction {
const DataTypePtr& result_type, size_t
input_rows_count,
const UInt8* src_null_map, UInt8*
dst_null_map) {
// check array nested column type and get data
- auto array_column =
check_and_get_column<ColumnArray>(*arguments[0].column);
+ auto left_column =
arguments[0].column->convert_to_full_column_if_const();
+ const auto array_column =
check_and_get_column<ColumnArray>(*left_column);
DCHECK(array_column != nullptr);
Review Comment:
if can sure array_column is `ColumnArray`, not need to call
`check_and_get_column`, use `reinterpret_cast`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
