github-actions[bot] commented on code in PR #43351:
URL: https://github.com/apache/doris/pull/43351#discussion_r1830567687
##########
be/src/olap/comparison_predicate.h:
##########
@@ -204,12 +204,23 @@ class ComparisonPredicateBase : public ColumnPredicate {
return bf->test_bytes(_value.data, _value.size);
} else {
// DecimalV2 using decimal12_t in bloom filter, should convert
value to decimal12_t
- // Datev1/DatetimeV1 using VecDatetimeValue in bloom filter,
NO need to convert.
if constexpr (Type == PrimitiveType::TYPE_DECIMALV2) {
decimal12_t decimal12_t_val(_value.int_value(),
_value.frac_value());
return bf->test_bytes(
const_cast<char*>(reinterpret_cast<const
char*>(&decimal12_t_val)),
sizeof(decimal12_t));
+ // Datev1 using uint24_t in bloom filter
+ } else if constexpr (Type == PrimitiveType::TYPE_DATE) {
+ uint24_t date_value = (uint24_t)_value.to_olap_date();
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto date_value = (uint24_t)_value.to_olap_date();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
