morrySnow opened a new issue, #9403:
URL: https://github.com/apache/incubator-doris/issues/9403

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Description
   
   fix fe code style in multi steps.
   this is step 1.
   Open no impact checks and fix whitespace errors
   
   ### Solution
   
   1. Add Spotless plugin and do some simple format(1198 files changed, 3205 
insertions(+), 4350 deletions(-))
        a. end with new line
        b. trim trailing whitespace
        c. replace tab indent with 4 spaces indent
        d. license header check
        e. adjust the order of import to "static, org.apache.doris, third 
party, java"
        f. remove unused imports
        g. make sure all files are encoding by utf-8
        h. make sure all files line ending by LF
   
   2. Add checkstyle rules but set default severity to warning to avoid compile 
failed.
   
   3. set some rules' severity to error in Checkstyle since no lines in doris 
break these rules(0 files, 0 lines)
        a. Merge conflicts unresolved
        b. Avoid using corresponding octal or Unicode escape
        c. Avoid Escaped Unicode Characters
        d. No Line Wrap
        e. Package Name
        f. Type Name
        g. Annotation Location
        h. Interface Type Parameter 
        i. CatchParameterName
        j. Pattern Variable Name
        k. Record Component Name
        l. Record Type Parameter Name
        m. Method Type Parameter Name
   
   4. Set below rules severity to error in Checkstyle since these had done by 
splotless(12 files, 177 lines)
        a. Redundant Import
        b. Custom Import Order
        c. Unused Imports
        d. Avoid Star Import
        e. tab character in file
        f. Newline At End Of File
        g. Trailing whitespace found
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to