xinyiZzz commented on code in PR #9379:
URL: https://github.com/apache/incubator-doris/pull/9379#discussion_r865745858
##########
be/src/olap/compaction.cpp:
##########
@@ -136,7 +136,12 @@ Status Compaction::do_compaction_impl(int64_t permits) {
int64_t current_max_version;
{
std::shared_lock rdlock(_tablet->get_header_lock());
- current_max_version =
_tablet->rowset_with_max_version()->end_version();
Review Comment:
> 1. The tablet should not have rowset because when the table is created BE
will add 0-1 rowset to the tablet.
> 2. I think we should be careful with this case... Maybe should deep dive
some code.
I agree, these two cases are not normal, maybe the tablet was deleted during
compaction, or invalid?
At present this is the previous solution, there may be a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
