eldenmoon commented on code in PR #43003:
URL: https://github.com/apache/doris/pull/43003#discussion_r1827485979
##########
be/src/olap/tablet_schema.cpp:
##########
@@ -902,14 +902,13 @@ void TabletColumn::append_sparse_column(TabletColumn
column) {
_num_sparse_columns++;
}
-void TabletSchema::append_index(TabletIndex index) {
+void TabletSchema::append_index(TabletIndex&& index) {
_indexes.push_back(std::move(index));
}
void TabletSchema::update_index(const TabletColumn& col, TabletIndex index) {
- int32_t col_unique_id = col.unique_id();
- const std::string& suffix_path =
- col.has_path_info() ?
escape_for_path_name(col.path_info_ptr()->get_path()) : "";
+ int32_t col_unique_id = col.is_extracted_column() ? col.parent_unique_id()
: col.unique_id();
Review Comment:
i think it's ok to modify this logic, since, update_index may not be called
for variant type before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
