xzj7019 commented on code in PR #42640:
URL: https://github.com/apache/doris/pull/42640#discussion_r1827243284


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -228,6 +230,44 @@ public Plan planWithLock(LogicalPlan plan, 
PhysicalProperties requireProperties,
         }
     }
 
+    /**

Review Comment:
   1. better to add this into pr desc
   2. double-check the basic benchmark such as tpcds 1T olap/external table 
performance, after removing the config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to