Mryange commented on code in PR #42998: URL: https://github.com/apache/doris/pull/42998#discussion_r1825669340
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -1772,15 +1772,17 @@ uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_ } } + const uint16_t original_size = selected_size; //If all predicates are always_true, then return directly. if (all_pred_always_true || !_is_need_vec_eval) { - for (uint16_t i = 0; i < selected_size; ++i) { + for (uint16_t i = 0; i < original_size; ++i) { sel_rowid_idx[i] = i; } - return selected_size; + // All preds are always_true, so return immediately and update the profile statistics here. + _opts.stats->vec_cond_input_rows += original_size; Review Comment: to maintain consistency with the code below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org