xinyiZzz commented on code in PR #9301: URL: https://github.com/apache/incubator-doris/pull/9301#discussion_r863551392
########## be/src/runtime/mem_pool.cpp: ########## @@ -41,7 +41,7 @@ const int MemPool::MAX_CHUNK_SIZE; const int MemPool::DEFAULT_ALIGNMENT; uint32_t MemPool::k_zero_length_region_ alignas(std::max_align_t) = MEM_POOL_POISON; -MemPool::MemPool(MemTracker* mem_tracker) +MemPool::MemPool(const std::shared_ptr<MemTracker>& mem_tracker) Review Comment: For convenience as a parameter. After a second thought, I'll change back to using `MemTracker*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
