HappenLee commented on code in PR #9314:
URL: https://github.com/apache/incubator-doris/pull/9314#discussion_r862596558
##########
be/src/vec/exec/vbroker_scanner.cpp:
##########
@@ -21,25 +21,40 @@
#include <iostream>
#include <sstream>
+#include "exec/text_converter.h"
#include "exec/exec_node.h"
#include "exprs/expr_context.h"
#include "exec/plain_text_line_reader.h"
+#include "util/utf8_check.h"
namespace doris::vectorized {
+
+bool is_null(const Slice& slice) {
+ return slice.size == 2 && slice.data[0] == '\\' && slice.data[1] == 'N';
+}
+
VBrokerScanner::VBrokerScanner(RuntimeState* state, RuntimeProfile* profile,
const TBrokerScanRangeParams& params,
const std::vector<TBrokerRangeDesc>& ranges,
const std::vector<TNetworkAddress>&
broker_addresses,
const std::vector<TExpr>& pre_filter_texprs,
ScannerCounter* counter)
: BrokerScanner(state, profile, params, ranges, broker_addresses,
pre_filter_texprs,
- counter) {}
+ counter) {
+ _text_converter.reset(new (std::nothrow) TextConverter('\\'));
+}
-Status VBrokerScanner::get_next(std::vector<MutableColumnPtr>& columns, bool*
eof) {
+Status VBrokerScanner::get_next(Block* output_block, bool* eof) {
SCOPED_TIMER(_read_timer);
const int batch_size = _state->batch_size();
+ std::shared_ptr<vectorized::Block> tmp_block(std::make_shared<Block>());
Review Comment:
why define tmp_block here ？ should in `_fill_dest_block`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
