github-actions[bot] commented on code in PR #42898:
URL: https://github.com/apache/doris/pull/42898#discussion_r1821973218
##########
be/src/pipeline/exec/aggregation_source_operator.cpp:
##########
@@ -94,18 +92,9 @@ Status
AggLocalState::_create_agg_status(vectorized::AggregateDataPtr data) {
return Status::OK();
}
-Status AggLocalState::_destroy_agg_status(vectorized::AggregateDataPtr data) {
- auto& shared_state = *Base::_shared_state;
- for (int i = 0; i < shared_state.aggregate_evaluators.size(); ++i) {
- shared_state.aggregate_evaluators[i]->function()->destroy(
- data + shared_state.offsets_of_aggregate_states[i]);
- }
- return Status::OK();
-}
-
-Status AggLocalState::_serialize_with_serialized_key_result(RuntimeState*
state,
- vectorized::Block*
block, bool* eos) {
- SCOPED_TIMER(_serialize_result_timer);
+Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state,
Review Comment:
warning: function '_get_results_with_serialized_key' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/aggregation_source_operator.cpp:94:** 115 lines
including whitespace and comments (threshold 80)
```cpp
Status AggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^
```
</details>
##########
be/src/pipeline/exec/streaming_aggregation_operator.cpp:
##########
@@ -848,12 +841,12 @@ Status
StreamingAggLocalState::_get_with_serialized_key_result(RuntimeState* sta
return Status::OK();
}
-Status StreamingAggLocalState::_serialize_without_key(RuntimeState* state,
vectorized::Block* block,
+Status StreamingAggLocalState::_get_results_without_key(RuntimeState* state,
vectorized::Block* block,
Review Comment:
warning: method '_get_results_without_key' can be made const
[readability-make-member-function-const]
be/src/pipeline/exec/streaming_aggregation_operator.cpp:844:
```diff
- bool* eos) {
+ bool* eos) const {
```
be/src/pipeline/exec/streaming_aggregation_operator.h:67:
```diff
- Status _get_results_without_key(RuntimeState* state,
vectorized::Block* block, bool* eos);
+ Status _get_results_without_key(RuntimeState* state,
vectorized::Block* block, bool* eos) const;
```
##########
be/src/pipeline/exec/streaming_aggregation_operator.cpp:
##########
@@ -892,10 +885,10 @@ Status
StreamingAggLocalState::_serialize_without_key(RuntimeState* state, vecto
return Status::OK();
}
-Status
StreamingAggLocalState::_serialize_with_serialized_key_result(RuntimeState*
state,
+Status StreamingAggLocalState::_get_results_with_serialized_key(RuntimeState*
state,
Review Comment:
warning: function '_get_results_with_serialized_key' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status
StreamingAggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/streaming_aggregation_operator.cpp:887:** 110 lines
including whitespace and comments (threshold 80)
```cpp
Status
StreamingAggLocalState::_get_results_with_serialized_key(RuntimeState* state,
^
```
</details>
##########
be/src/pipeline/exec/aggregation_source_operator.cpp:
##########
@@ -30,20 +30,18 @@ namespace doris::pipeline {
AggLocalState::AggLocalState(RuntimeState* state, OperatorXBase* parent)
: Base(state, parent),
_get_results_timer(nullptr),
- _serialize_result_timer(nullptr),
_hash_table_iterate_timer(nullptr),
_insert_keys_to_column_timer(nullptr),
- _serialize_data_timer(nullptr) {}
+ _insert_values_to_column_timer(nullptr) {}
Review Comment:
warning: member initializer for '_insert_values_to_column_timer' is
redundant [modernize-use-default-member-init]
```suggestion
{}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
