yiguolei commented on code in PR #42857: URL: https://github.com/apache/doris/pull/42857#discussion_r1821833177
########## be/src/vec/exec/scan/scanner_scheduler.cpp: ########## @@ -212,8 +211,6 @@ std::unique_ptr<ThreadPoolToken> ScannerScheduler::new_limited_scan_pool_token( void ScannerScheduler::_scanner_scan(std::shared_ptr<ScannerContext> ctx, std::shared_ptr<ScanTask> scan_task) { - // record the time from scanner submission to actual execution in nanoseconds - ctx->incr_ctx_scheduling_time(GetCurrentTimeNanos() - scan_task->last_submit_time); Review Comment: 这个counter 需要保留,他记录的是在queue 里的等待时间,如果这个时间太长,我们的schedule 策略可能有问题。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org