xzj7019 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1820894518
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression>
getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
Does it mean the original hasAgg judgement actually contains any unexpected
pulled up agg cases, after this restriction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
