KassieZ commented on code in PR #1240:
URL: https://github.com/apache/doris-website/pull/1240#discussion_r1820428913


##########
docs/table-design/schema-change.md:
##########
@@ -97,31 +97,71 @@ ALTER TABLE table_name ADD COLUMN column_name column_type 
[KEY | agg_type] [DEFA
 
 ### Examples
 
-**1. Adding a key column `new_col` (non-aggregate model) after col1 to 
`example_rollup_index`**
+#### non-aggregate model

Review Comment:
   `**Non-aggregate Model**`



##########
docs/table-design/schema-change.md:
##########
@@ -97,31 +97,71 @@ ALTER TABLE table_name ADD COLUMN column_name column_type 
[KEY | agg_type] [DEFA
 
 ### Examples
 
-**1. Adding a key column `new_col` (non-aggregate model) after col1 to 
`example_rollup_index`**
+#### non-aggregate model
+
+table's DDL:
+```sql
+CREATE TABLE IF NOT EXISTS example_db.my_table(
+    col1 int,
+    col2 int,
+    col3 int,
+    col4 int,
+    col5 int
+) DUPLICATE KEY(col1, col2, col3)
+DISTRIBUTED BY RANDOM BUCKETS 1
+ROLLUP (
+   example_rollup_index (col1, col3, col4, col5)
+)
+PROPERTIES (
+   "replication_num" = "1"
+)
+```
+
+**1. Adding a key column `new_col` after col1 to `example_rollup_index`**
 
 ```sql
 ALTER TABLE example_db.my_table
 ADD COLUMN new_col INT KEY DEFAULT "0" AFTER col1
 TO example_rollup_index;
 ```
 
-**2. Adding a value column `new_col` (non-aggregate model) with a default 
value of 0 after col1 to `example_rollup_index`**
+**2. Adding a value column `new_col` with a default value of 0 after col1 to 
`example_rollup_index`**
 
 ```sql
 ALTER TABLE example_db.my_table   
 ADD COLUMN new_col INT DEFAULT "0" AFTER col1    
 TO example_rollup_index;
 ```
 
-**3. Adding a Key column `new_col` (aggregate model) after col1 to 
`example_rollup_index`**
+#### aggregate model

Review Comment:
   `**Aggregate Model**`



##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/index/ngram-bloomfilter-index.md:
##########
@@ -151,6 +151,14 @@ curl --location-trusted -u root: -T 
amazon_reviews_2014.snappy.parquet -H "forma
 curl --location-trusted -u root: -T amazon_reviews_2015.snappy.parquet -H 
"format:parquet" http://127.0.0.1:8030/api/${DB}/amazon_reviews/_stream_load
 ```
 
+:::info
+上面的文件可能超过 10 GB,您可能需要调整 be.conf 的 streaming_load_max_mb 防止超过 stream load 
文件上传大小的限制,可以通过下面方式动态调整

Review Comment:
   Stream Load



##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/index/ngram-bloomfilter-index.md:
##########
@@ -151,6 +151,14 @@ curl --location-trusted -u root: -T 
amazon_reviews_2014.snappy.parquet -H "forma
 curl --location-trusted -u root: -T amazon_reviews_2015.snappy.parquet -H 
"format:parquet" http://127.0.0.1:8030/api/${DB}/amazon_reviews/_stream_load
 ```
 
+:::info
+上面的文件可能超过 10 GB,您可能需要调整 be.conf 的 streaming_load_max_mb 防止超过 stream load 
文件上传大小的限制,可以通过下面方式动态调整
+```bash
+curl -X POST 
http://{be_ip}:{be_http_port}/api/update_config?streaming_load_max_mb=32768
+```
+需要每台 be 都执行上述命令。

Review Comment:
   BE



##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/schema-change.md:
##########
@@ -97,31 +97,71 @@ ALTER TABLE table_name ADD COLUMN column_name column_type 
[KEY | agg_type] [DEFA
 
 ### 示例
 
-**1. 向 `example_rollup_index ` 的 col1 后添加一个 Key 列 `new_col` (非聚合模型)**
+#### 非聚合模型
+
+建表语句:
+```sql
+CREATE TABLE IF NOT EXISTS example_db.my_table(
+    col1 int,
+    col2 int,
+    col3 int,
+    col4 int,
+    col5 int
+) DUPLICATE KEY(col1, col2, col3)
+DISTRIBUTED BY RANDOM BUCKETS 1
+ROLLUP (
+   example_rollup_index (col1, col3, col4, col5)
+)
+PROPERTIES (
+   "replication_num" = "1"
+)
+```
+
+**1. 向 `example_rollup_index ` 的 col1 后添加一个 Key 列 `new_col`**
 
 ```sql
 ALTER TABLE example_db.my_table
 ADD COLUMN new_col INT KEY DEFAULT "0" AFTER col1
 TO example_rollup_index;
 ```
 
-**2. 向 `example_rollup_index` 的 col1 后添加一个 Value 列 `new_col` (非聚合模型)**
+**2. 向 `example_rollup_index` 的 col1 后添加一个 Value 列 `new_col`**
 
 ```sql
 ALTER TABLE example_db.my_table   
 ADD COLUMN new_col INT DEFAULT "0" AFTER col1    
 TO example_rollup_index;
 ```
 
-**3. 向 `example_rollup_index` 的 col1 后添加一个 Key 列 `new_col` (聚合模型)**
+#### 聚合模型

Review Comment:
   `**聚合模型**`



##########
docs/table-design/schema-change.md:
##########
@@ -261,6 +318,24 @@ ALTER TABLE table_name ORDER BY (column_name1, 
column_name2, ...)
 
 ### Example

Review Comment:
   `### Example 1`



##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/table-design/schema-change.md:
##########
@@ -261,6 +318,24 @@ ALTER TABLE table_name ORDER BY (column_name1, 
column_name2, ...)
 
 ### 示例

Review Comment:
   示例 1



##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/schema-change.md:
##########
@@ -97,31 +97,71 @@ ALTER TABLE table_name ADD COLUMN column_name column_type 
[KEY | agg_type] [DEFA
 
 ### 示例
 
-**1. 向 `example_rollup_index ` 的 col1 后添加一个 Key 列 `new_col` (非聚合模型)**
+#### 非聚合模型

Review Comment:
   `**非聚合类型**`
   
   建议到三级标题,超过时可以使用加粗



##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/schema-change.md:
##########
@@ -486,4 +580,4 @@ ADMIN SET FRONTEND CONFIG ("disable_balance" = "true");
 
 ## 更多参考
 
-关于 Schema Change 使用的更多详细语法及最佳实践,请参阅 [ALTER TABLE 
COLUMN](../sql-manual/sql-statements/Data-Definition-Statements/Alter/ALTER-TABLE-COLUMN)
 命令手册,你也可以在 MySQL 客户端命令行下输入 `HELP ALTER TABLE COLUMN` 获取更多帮助信息。
\ No newline at end of file
+关于 Schema Change 使用的更多详细语法及最佳实践,请参阅 [ALTER TABLE 
COLUMN](../sql-manual/sql-statements/Data-Definition-Statements/Alter/ALTER-TABLE-COLUMN)
 命令手册,你也可以在 MySQL 客户端命令行下输入 `HELP ALTER TABLE COLUMN` 获取更多帮助信息。

Review Comment:
   Help 命令当前无法使用,是否先删除
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to