github-actions[bot] commented on code in PR #42680:
URL: https://github.com/apache/doris/pull/42680#discussion_r1820043359
##########
be/src/olap/tablet_schema.cpp:
##########
@@ -1556,6 +1559,7 @@ bool operator==(const TabletSchema& a, const
TabletSchema& b) {
if (a._enable_single_replica_compaction !=
b._enable_single_replica_compaction) return false;
if (a._store_row_column != b._store_row_column) return false;
if (a._row_store_page_size != b._row_store_page_size) return false;
+ if (a._storage_page_size != b._storage_page_size) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (a._storage_page_size != b._storage_page_size) { return false;
}
```
##########
be/src/olap/rowset/segment_v2/options.h:
##########
@@ -25,6 +25,7 @@ namespace segment_v2 {
static constexpr size_t DEFAULT_PAGE_SIZE = 1024 * 1024; // default size: 1M
constexpr long ROW_STORE_PAGE_SIZE_DEFAULT_VALUE = 16384; // default row store
page size: 16KB
+static constexpr int64_t STORAGE_PAGE_SIZE_DEFAULT_VALUE = 65536;
Review Comment:
warning: unknown type name 'int64_t' [clang-diagnostic-error]
```cpp
static constexpr int64_t STORAGE_PAGE_SIZE_DEFAULT_VALUE = 65536;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
