amorynan commented on code in PR #42416:
URL: https://github.com/apache/doris/pull/42416#discussion_r1818905699
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -642,11 +642,18 @@ public static Set<String>
analyzeBloomFilterColumns(Map<String, String> properti
if (column.getName().equalsIgnoreCase(bfColumn)) {
PrimitiveType type = column.getDataType();
- // tinyint/float/double columns don't support
+ // now we only support BloomFilter on (same behavior
with BE):
+ // smallint/int/bigint/largeint
+ // string/varchar/char/variant
+ // date/datetime/datev2/datetimev2
+ // decimal/decimal32/decimal64/decimal128I/decimal256
+ // ipv4/ipv6
+ //
// key columns and none/replace aggregate non-key
columns support
- if (type == PrimitiveType.TINYINT || type ==
PrimitiveType.FLOAT
- || type == PrimitiveType.DOUBLE || type ==
PrimitiveType.BOOLEAN
- || type.isComplexType()) {
+ if (!((type == PrimitiveType.SMALLINT || type ==
PrimitiveType.INT
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
