github-actions[bot] commented on code in PR #42379:
URL: https://github.com/apache/doris/pull/42379#discussion_r1818352597
##########
be/src/cloud/cloud_cumulative_compaction.cpp:
##########
@@ -351,14 +351,15 @@ Status CloudCumulativeCompaction::modify_rowsets() {
stats.num_rows(),
stats.data_size());
}
}
- if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
+ if (config::enable_cloud_delete_old_version_delete_bitmap &&
+ _tablet->keys_type() == KeysType::UNIQUE_KEYS &&
_tablet->enable_unique_key_merge_on_write() && _input_rowsets.size()
!= 1) {
- process_old_version_delete_bitmap();
+ RETURN_IF_ERROR(process_old_version_delete_bitmap());
}
return Status::OK();
}
-void CloudCumulativeCompaction::process_old_version_delete_bitmap() {
+Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {
Review Comment:
warning: function 'process_old_version_delete_bitmap' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {
^
```
<details>
<summary>Additional context</summary>
**be/src/cloud/cloud_cumulative_compaction.cpp:361:** 94 lines including
whitespace and comments (threshold 80)
```cpp
Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {
^
```
</details>
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1853,6 +1856,143 @@ void
MetaServiceImpl::update_delete_bitmap(google::protobuf::RpcController* cont
<< " total_size=" << total_size << " unlock=" << unlock;
}
+void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController*
controller,
Review Comment:
warning: function 'update_delete_bitmap2' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController*
controller,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service.cpp:1858:** 132 lines including
whitespace and comments (threshold 80)
```cpp
void MetaServiceImpl::update_delete_bitmap2(google::protobuf::RpcController*
controller,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
