xzj7019 commented on code in PR #42033:
URL: https://github.com/apache/doris/pull/42033#discussion_r1818335247
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -355,26 +355,10 @@ public class Rewriter extends AbstractBatchJobExecutor {
bottomUp(new EliminateJoinByFK()),
topDown(new EliminateJoinByUnique())
),
-
- // this rule should be after topic "Column pruning and infer
predicate"
- topic("Join pull up",
- topDown(
- new EliminateFilter(),
- new PushDownFilterThroughProject(),
- new MergeProjects()
- ),
- topDown(
- new PullUpJoinFromUnionAll()
- ),
- custom(RuleType.COLUMN_PRUNING, ColumnPruning::new),
Review Comment:
make sure the new rule sets can replace the original one's column pruning
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
