github-actions[bot] commented on code in PR #42269: URL: https://github.com/apache/doris/pull/42269#discussion_r1817969502
########## be/test/vec/columns/common_column_test.h: ########## @@ -0,0 +1,766 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest-message.h> +#include <gtest/gtest-test-part.h> +#include <gtest/gtest.h> + +#include "olap/schema.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_map.h" +#include "vec/columns/columns_number.h" +#include "vec/core/field.h" +#include "vec/core/sort_block.h" +#include "vec/core/sort_description.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_map.h" + +// this test is gonna to be a column test template for all column which should make ut test to coverage the function defined in column +// for example column_array should test this function: +// size, reserve, resize, empty, byte_size, allocated_bytes, clone_resized, +// get_shrinked_column, filter, filter_by_selector, serialize_vec, deserialize_vec, get_max_row_byte_size +// +namespace doris::vectorized { + +class CommonColumnTest : public ::testing::Test { +public: + void SetUp() override { + col_str = ColumnString::create(); + col_str->insert_data("aaa", 3); + col_str->insert_data("bb", 2); + col_str->insert_data("cccc", 4); + + col_int = ColumnInt64::create(); + col_int->insert_value(1); + col_int->insert_value(2); + col_int->insert_value(3); + + col_dcm = ColumnDecimal64::create(0, 3); + col_dcm->insert_value(1.23); + col_dcm->insert_value(4.56); + col_dcm->insert_value(7.89); + + col_arr = ColumnArray::create(ColumnInt64::create(), ColumnArray::ColumnOffsets::create()); + Array array1 = {1, 2, 3}; + Array array2 = {4}; + col_arr->insert(array1); + col_arr->insert(Array()); + col_arr->insert(array2); + + col_map = ColumnMap::create(ColumnString::create(), ColumnInt64::create(), + ColumnArray::ColumnOffsets::create()); + Array k1 = {"a", "b", "c"}; + Array v1 = {1, 2, 3}; + Array k2 = {"d"}; + Array v2 = {4}; + Array a = Array(); + Map map1, map2, map3; + map1.push_back(k1); + map1.push_back(v1); + col_map->insert(map1); + map3.push_back(a); + map3.push_back(a); + col_map->insert(map3); + map2.push_back(k2); + map2.push_back(v2); + col_map->insert(map2); + } + + ColumnString::MutablePtr col_str; + ColumnInt64::MutablePtr col_int; + ColumnDecimal64::MutablePtr col_dcm; + ColumnArray::MutablePtr col_arr; + ColumnMap::MutablePtr col_map; + + void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, Review Comment: warning: function 'checkColumn' has cognitive complexity of 75 (threshold 50) [readability-function-cognitive-complexity] ```cpp void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, ^ ``` <details> <summary>Additional context</summary> **be/test/vec/columns/common_column_test.h:93:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (WhichDataType(dataType).is_map()) { ^ ``` **be/test/vec/columns/common_column_test.h:101:** +1, nesting level increased to 1 ```cpp } else { ^ ``` **be/test/vec/columns/common_column_test.h:102:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (WhichDataType(dataType).is_int8()) { ^ ``` **be/test/vec/columns/common_column_test.h:105:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:108:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int16()) { ^ ``` **be/test/vec/columns/common_column_test.h:111:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:114:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int32()) { ^ ``` **be/test/vec/columns/common_column_test.h:117:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:120:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int64()) { ^ ``` **be/test/vec/columns/common_column_test.h:123:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:126:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int128()) { ^ ``` **be/test/vec/columns/common_column_test.h:129:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:132:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_float32()) { ^ ``` **be/test/vec/columns/common_column_test.h:135:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:138:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_float64()) { ^ ``` **be/test/vec/columns/common_column_test.h:141:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:144:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint8()) { ^ ``` **be/test/vec/columns/common_column_test.h:147:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:150:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint16()) { ^ ``` **be/test/vec/columns/common_column_test.h:153:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:156:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint32()) { ^ ``` **be/test/vec/columns/common_column_test.h:159:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:162:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint64()) { ^ ``` **be/test/vec/columns/common_column_test.h:165:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:168:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal()) { ^ ``` **be/test/vec/columns/common_column_test.h:171:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:174:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal32()) { ^ ``` **be/test/vec/columns/common_column_test.h:177:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:180:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal64()) { ^ ``` **be/test/vec/columns/common_column_test.h:183:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:186:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal128v2()) { ^ ``` **be/test/vec/columns/common_column_test.h:189:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:192:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal128v3()) { ^ ``` **be/test/vec/columns/common_column_test.h:195:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:198:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal256()) { ^ ``` **be/test/vec/columns/common_column_test.h:201:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:204:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/test/vec/columns/common_column_test.h:205:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` </details> ########## be/test/vec/columns/common_column_test.h: ########## @@ -0,0 +1,766 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest-message.h> +#include <gtest/gtest-test-part.h> +#include <gtest/gtest.h> + +#include "olap/schema.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_map.h" +#include "vec/columns/columns_number.h" +#include "vec/core/field.h" +#include "vec/core/sort_block.h" +#include "vec/core/sort_description.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_map.h" + +// this test is gonna to be a column test template for all column which should make ut test to coverage the function defined in column +// for example column_array should test this function: +// size, reserve, resize, empty, byte_size, allocated_bytes, clone_resized, +// get_shrinked_column, filter, filter_by_selector, serialize_vec, deserialize_vec, get_max_row_byte_size +// +namespace doris::vectorized { + +class CommonColumnTest : public ::testing::Test { +public: + void SetUp() override { + col_str = ColumnString::create(); + col_str->insert_data("aaa", 3); + col_str->insert_data("bb", 2); + col_str->insert_data("cccc", 4); + + col_int = ColumnInt64::create(); + col_int->insert_value(1); + col_int->insert_value(2); + col_int->insert_value(3); + + col_dcm = ColumnDecimal64::create(0, 3); + col_dcm->insert_value(1.23); + col_dcm->insert_value(4.56); + col_dcm->insert_value(7.89); + + col_arr = ColumnArray::create(ColumnInt64::create(), ColumnArray::ColumnOffsets::create()); + Array array1 = {1, 2, 3}; + Array array2 = {4}; + col_arr->insert(array1); + col_arr->insert(Array()); + col_arr->insert(array2); + + col_map = ColumnMap::create(ColumnString::create(), ColumnInt64::create(), + ColumnArray::ColumnOffsets::create()); + Array k1 = {"a", "b", "c"}; + Array v1 = {1, 2, 3}; + Array k2 = {"d"}; + Array v2 = {4}; + Array a = Array(); + Map map1, map2, map3; + map1.push_back(k1); + map1.push_back(v1); + col_map->insert(map1); + map3.push_back(a); + map3.push_back(a); + col_map->insert(map3); + map2.push_back(k2); + map2.push_back(v2); + col_map->insert(map2); + } + + ColumnString::MutablePtr col_str; + ColumnInt64::MutablePtr col_int; + ColumnDecimal64::MutablePtr col_dcm; + ColumnArray::MutablePtr col_arr; + ColumnMap::MutablePtr col_map; + + void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, Review Comment: warning: function 'checkColumn' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, ^ ``` <details> <summary>Additional context</summary> **be/test/vec/columns/common_column_test.h:91:** 118 lines including whitespace and comments (threshold 80) ```cpp void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, ^ ``` </details> ########## be/test/vec/columns/common_column_test.h: ########## @@ -0,0 +1,766 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest-message.h> +#include <gtest/gtest-test-part.h> +#include <gtest/gtest.h> + +#include "olap/schema.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_map.h" +#include "vec/columns/columns_number.h" +#include "vec/core/field.h" +#include "vec/core/sort_block.h" +#include "vec/core/sort_description.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_map.h" + +// this test is gonna to be a column test template for all column which should make ut test to coverage the function defined in column +// for example column_array should test this function: +// size, reserve, resize, empty, byte_size, allocated_bytes, clone_resized, +// get_shrinked_column, filter, filter_by_selector, serialize_vec, deserialize_vec, get_max_row_byte_size +// +namespace doris::vectorized { + +class CommonColumnTest : public ::testing::Test { +public: + void SetUp() override { + col_str = ColumnString::create(); + col_str->insert_data("aaa", 3); + col_str->insert_data("bb", 2); + col_str->insert_data("cccc", 4); + + col_int = ColumnInt64::create(); + col_int->insert_value(1); + col_int->insert_value(2); + col_int->insert_value(3); + + col_dcm = ColumnDecimal64::create(0, 3); + col_dcm->insert_value(1.23); + col_dcm->insert_value(4.56); + col_dcm->insert_value(7.89); + + col_arr = ColumnArray::create(ColumnInt64::create(), ColumnArray::ColumnOffsets::create()); + Array array1 = {1, 2, 3}; + Array array2 = {4}; + col_arr->insert(array1); + col_arr->insert(Array()); + col_arr->insert(array2); + + col_map = ColumnMap::create(ColumnString::create(), ColumnInt64::create(), + ColumnArray::ColumnOffsets::create()); + Array k1 = {"a", "b", "c"}; + Array v1 = {1, 2, 3}; + Array k2 = {"d"}; + Array v2 = {4}; + Array a = Array(); + Map map1, map2, map3; + map1.push_back(k1); + map1.push_back(v1); + col_map->insert(map1); + map3.push_back(a); + map3.push_back(a); + col_map->insert(map3); + map2.push_back(k2); + map2.push_back(v2); + col_map->insert(map2); + } + + ColumnString::MutablePtr col_str; + ColumnInt64::MutablePtr col_int; + ColumnDecimal64::MutablePtr col_dcm; + ColumnArray::MutablePtr col_arr; + ColumnMap::MutablePtr col_map; + + void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, + size_t column_size) { + if (WhichDataType(dataType).is_map()) { + auto map1 = check_and_get_column<ColumnMap>(col1); + auto map2 = check_and_get_column<ColumnMap>(col2); + const DataTypeMap& rhs_map = static_cast<const DataTypeMap&>(dataType); + checkColumn(map1->get_keys(), map2->get_keys(), *rhs_map.get_key_type(), + map1->get_keys().size()); + checkColumn(map2->get_values(), map2->get_values(), *rhs_map.get_value_type(), + map1->get_values().size()); + } else { + if (WhichDataType(dataType).is_int8()) { + auto c1 = check_and_get_column<ColumnInt8>(col1); + auto c2 = check_and_get_column<ColumnInt8>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int16()) { + auto c1 = check_and_get_column<ColumnInt16>(col1); + auto c2 = check_and_get_column<ColumnInt16>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int32()) { + auto c1 = check_and_get_column<ColumnInt32>(col1); + auto c2 = check_and_get_column<ColumnInt32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int64()) { + auto c1 = check_and_get_column<ColumnInt64>(col1); + auto c2 = check_and_get_column<ColumnInt64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int128()) { + auto c1 = check_and_get_column<ColumnInt128>(col1); + auto c2 = check_and_get_column<ColumnInt128>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_float32()) { + auto c1 = check_and_get_column<ColumnFloat32>(col1); + auto c2 = check_and_get_column<ColumnFloat32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_float64()) { + auto c1 = check_and_get_column<ColumnFloat64>(col1); + auto c2 = check_and_get_column<ColumnFloat64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint8()) { + auto c1 = check_and_get_column<ColumnUInt8>(col1); + auto c2 = check_and_get_column<ColumnUInt8>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint16()) { + auto c1 = check_and_get_column<ColumnUInt16>(col1); + auto c2 = check_and_get_column<ColumnUInt16>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint32()) { + auto c1 = check_and_get_column<ColumnUInt32>(col1); + auto c2 = check_and_get_column<ColumnUInt32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint64()) { + auto c1 = check_and_get_column<ColumnUInt64>(col1); + auto c2 = check_and_get_column<ColumnUInt64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal()) { + auto c1 = check_and_get_column<ColumnDecimal64>(col1); + auto c2 = check_and_get_column<ColumnDecimal64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal32()) { + auto c1 = check_and_get_column<ColumnDecimal32>(col1); + auto c2 = check_and_get_column<ColumnDecimal32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal64()) { + auto c1 = check_and_get_column<ColumnDecimal64>(col1); + auto c2 = check_and_get_column<ColumnDecimal64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal128v2()) { + auto c1 = check_and_get_column<ColumnDecimal128V2>(col1); + auto c2 = check_and_get_column<ColumnDecimal128V2>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal128v3()) { + auto c1 = check_and_get_column<ColumnDecimal128V3>(col1); + auto c2 = check_and_get_column<ColumnDecimal128V3>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal256()) { + auto c1 = check_and_get_column<ColumnDecimal<Decimal256>>(col1); + auto c2 = check_and_get_column<ColumnDecimal<Decimal256>>(col1); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else { + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(col1.get_data_at(i), col2.get_data_at(i)); + } + } + } + } + + void printColumn(const IColumn& column, const IDataType& dataType) { Review Comment: warning: function 'printColumn' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void printColumn(const IColumn& column, const IDataType& dataType) { ^ ``` <details> <summary>Additional context</summary> **be/test/vec/columns/common_column_test.h:212:** 135 lines including whitespace and comments (threshold 80) ```cpp void printColumn(const IColumn& column, const IDataType& dataType) { ^ ``` </details> ########## be/test/vec/columns/common_column_test.h: ########## @@ -0,0 +1,766 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest-message.h> +#include <gtest/gtest-test-part.h> +#include <gtest/gtest.h> + +#include "olap/schema.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_map.h" +#include "vec/columns/columns_number.h" +#include "vec/core/field.h" +#include "vec/core/sort_block.h" +#include "vec/core/sort_description.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_map.h" + +// this test is gonna to be a column test template for all column which should make ut test to coverage the function defined in column +// for example column_array should test this function: +// size, reserve, resize, empty, byte_size, allocated_bytes, clone_resized, +// get_shrinked_column, filter, filter_by_selector, serialize_vec, deserialize_vec, get_max_row_byte_size +// +namespace doris::vectorized { + +class CommonColumnTest : public ::testing::Test { +public: + void SetUp() override { + col_str = ColumnString::create(); + col_str->insert_data("aaa", 3); + col_str->insert_data("bb", 2); + col_str->insert_data("cccc", 4); + + col_int = ColumnInt64::create(); + col_int->insert_value(1); + col_int->insert_value(2); + col_int->insert_value(3); + + col_dcm = ColumnDecimal64::create(0, 3); + col_dcm->insert_value(1.23); + col_dcm->insert_value(4.56); + col_dcm->insert_value(7.89); + + col_arr = ColumnArray::create(ColumnInt64::create(), ColumnArray::ColumnOffsets::create()); + Array array1 = {1, 2, 3}; + Array array2 = {4}; + col_arr->insert(array1); + col_arr->insert(Array()); + col_arr->insert(array2); + + col_map = ColumnMap::create(ColumnString::create(), ColumnInt64::create(), + ColumnArray::ColumnOffsets::create()); + Array k1 = {"a", "b", "c"}; + Array v1 = {1, 2, 3}; + Array k2 = {"d"}; + Array v2 = {4}; + Array a = Array(); + Map map1, map2, map3; + map1.push_back(k1); + map1.push_back(v1); + col_map->insert(map1); + map3.push_back(a); + map3.push_back(a); + col_map->insert(map3); + map2.push_back(k2); + map2.push_back(v2); + col_map->insert(map2); + } + + ColumnString::MutablePtr col_str; + ColumnInt64::MutablePtr col_int; + ColumnDecimal64::MutablePtr col_dcm; + ColumnArray::MutablePtr col_arr; + ColumnMap::MutablePtr col_map; + + void checkColumn(const IColumn& col1, const IColumn& col2, const IDataType& dataType, + size_t column_size) { + if (WhichDataType(dataType).is_map()) { + auto map1 = check_and_get_column<ColumnMap>(col1); + auto map2 = check_and_get_column<ColumnMap>(col2); + const DataTypeMap& rhs_map = static_cast<const DataTypeMap&>(dataType); + checkColumn(map1->get_keys(), map2->get_keys(), *rhs_map.get_key_type(), + map1->get_keys().size()); + checkColumn(map2->get_values(), map2->get_values(), *rhs_map.get_value_type(), + map1->get_values().size()); + } else { + if (WhichDataType(dataType).is_int8()) { + auto c1 = check_and_get_column<ColumnInt8>(col1); + auto c2 = check_and_get_column<ColumnInt8>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int16()) { + auto c1 = check_and_get_column<ColumnInt16>(col1); + auto c2 = check_and_get_column<ColumnInt16>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int32()) { + auto c1 = check_and_get_column<ColumnInt32>(col1); + auto c2 = check_and_get_column<ColumnInt32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int64()) { + auto c1 = check_and_get_column<ColumnInt64>(col1); + auto c2 = check_and_get_column<ColumnInt64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_int128()) { + auto c1 = check_and_get_column<ColumnInt128>(col1); + auto c2 = check_and_get_column<ColumnInt128>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_float32()) { + auto c1 = check_and_get_column<ColumnFloat32>(col1); + auto c2 = check_and_get_column<ColumnFloat32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_float64()) { + auto c1 = check_and_get_column<ColumnFloat64>(col1); + auto c2 = check_and_get_column<ColumnFloat64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint8()) { + auto c1 = check_and_get_column<ColumnUInt8>(col1); + auto c2 = check_and_get_column<ColumnUInt8>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint16()) { + auto c1 = check_and_get_column<ColumnUInt16>(col1); + auto c2 = check_and_get_column<ColumnUInt16>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint32()) { + auto c1 = check_and_get_column<ColumnUInt32>(col1); + auto c2 = check_and_get_column<ColumnUInt32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_uint64()) { + auto c1 = check_and_get_column<ColumnUInt64>(col1); + auto c2 = check_and_get_column<ColumnUInt64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal()) { + auto c1 = check_and_get_column<ColumnDecimal64>(col1); + auto c2 = check_and_get_column<ColumnDecimal64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal32()) { + auto c1 = check_and_get_column<ColumnDecimal32>(col1); + auto c2 = check_and_get_column<ColumnDecimal32>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal64()) { + auto c1 = check_and_get_column<ColumnDecimal64>(col1); + auto c2 = check_and_get_column<ColumnDecimal64>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal128v2()) { + auto c1 = check_and_get_column<ColumnDecimal128V2>(col1); + auto c2 = check_and_get_column<ColumnDecimal128V2>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal128v3()) { + auto c1 = check_and_get_column<ColumnDecimal128V3>(col1); + auto c2 = check_and_get_column<ColumnDecimal128V3>(col2); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else if (WhichDataType(dataType).is_decimal256()) { + auto c1 = check_and_get_column<ColumnDecimal<Decimal256>>(col1); + auto c2 = check_and_get_column<ColumnDecimal<Decimal256>>(col1); + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(c1->get_element(i), c2->get_element(i)); + } + } else { + for (size_t i = 0; i < column_size; ++i) { + EXPECT_EQ(col1.get_data_at(i), col2.get_data_at(i)); + } + } + } + } + + void printColumn(const IColumn& column, const IDataType& dataType) { Review Comment: warning: function 'printColumn' has cognitive complexity of 96 (threshold 50) [readability-function-cognitive-complexity] ```cpp void printColumn(const IColumn& column, const IDataType& dataType) { ^ ``` <details> <summary>Additional context</summary> **be/test/vec/columns/common_column_test.h:214:** +1, including nesting penalty of 0, nesting level increased to 1 ```cpp if (WhichDataType(dataType).is_map()) { ^ ``` **be/test/vec/columns/common_column_test.h:220:** +1, nesting level increased to 1 ```cpp } else if (WhichDataType(dataType).is_array()) { ^ ``` **be/test/vec/columns/common_column_test.h:225:** +1, nesting level increased to 1 ```cpp } else { ^ ``` **be/test/vec/columns/common_column_test.h:228:** +2, including nesting penalty of 1, nesting level increased to 2 ```cpp if (WhichDataType(dataType).is_int8()) { ^ ``` **be/test/vec/columns/common_column_test.h:230:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:233:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int16()) { ^ ``` **be/test/vec/columns/common_column_test.h:235:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:238:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int32()) { ^ ``` **be/test/vec/columns/common_column_test.h:240:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:243:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int64()) { ^ ``` **be/test/vec/columns/common_column_test.h:245:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:248:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_int128()) { ^ ``` **be/test/vec/columns/common_column_test.h:250:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:253:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_float32()) { ^ ``` **be/test/vec/columns/common_column_test.h:255:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:258:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_float64()) { ^ ``` **be/test/vec/columns/common_column_test.h:260:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:263:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint8()) { ^ ``` **be/test/vec/columns/common_column_test.h:265:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:268:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint16()) { ^ ``` **be/test/vec/columns/common_column_test.h:270:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:273:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint32()) { ^ ``` **be/test/vec/columns/common_column_test.h:275:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:278:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint64()) { ^ ``` **be/test/vec/columns/common_column_test.h:280:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:283:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_uint128()) { ^ ``` **be/test/vec/columns/common_column_test.h:285:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:288:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal()) { ^ ``` **be/test/vec/columns/common_column_test.h:290:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:293:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal32()) { ^ ``` **be/test/vec/columns/common_column_test.h:295:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:298:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal64()) { ^ ``` **be/test/vec/columns/common_column_test.h:300:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:303:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal128v2()) { ^ ``` **be/test/vec/columns/common_column_test.h:305:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:308:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal128v3()) { ^ ``` **be/test/vec/columns/common_column_test.h:310:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:313:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_decimal256()) { ^ ``` **be/test/vec/columns/common_column_test.h:315:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:318:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_date()) { ^ ``` **be/test/vec/columns/common_column_test.h:320:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:323:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_date_time()) { ^ ``` **be/test/vec/columns/common_column_test.h:325:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:328:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_date_v2()) { ^ ``` **be/test/vec/columns/common_column_test.h:330:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:333:** +1, nesting level increased to 2 ```cpp } else if (WhichDataType(dataType).is_date_time_v2()) { ^ ``` **be/test/vec/columns/common_column_test.h:335:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` **be/test/vec/columns/common_column_test.h:338:** +1, nesting level increased to 2 ```cpp } else { ^ ``` **be/test/vec/columns/common_column_test.h:341:** +3, including nesting penalty of 2, nesting level increased to 3 ```cpp for (size_t i = 0; i < column_size; ++i) { ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
