github-actions[bot] commented on code in PR #42499:
URL: https://github.com/apache/doris/pull/42499#discussion_r1816456871
##########
be/src/vec/runtime/ip_address_cidr.h:
##########
@@ -96,14 +98,14 @@ struct IPAddressCIDR {
};
bool match_ipv4_subnet(uint32_t addr, uint32_t cidr_addr, uint8_t prefix) {
- uint32_t mask = (prefix >= 32) ? 0xffffffffu : ~(0xffffffffu >> prefix);
+ uint32_t mask = (prefix >= 32) ? 0xffffffffU : ~(0xffffffffU >> prefix);
return (addr & mask) == (cidr_addr & mask);
}
#if defined(__SSE2__) || defined(__aarch64__)
bool match_ipv6_subnet(const uint8_t* addr, const uint8_t* cidr_addr, uint8_t
prefix) {
- uint16_t mask = _mm_movemask_epi8(
+ uint16_t mask = (uint16_t)_mm_movemask_epi8(
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto mask = (uint16_t)_mm_movemask_epi8(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
