wary commented on code in PR #235:
URL:
https://github.com/apache/doris-spark-connector/pull/235#discussion_r1814654916
##########
spark-doris-connector/src/main/scala/org/apache/doris/spark/load/StreamLoader.scala:
##########
@@ -393,7 +394,8 @@ class StreamLoader(settings: SparkSettings, isStreaming:
Boolean) extends Loader
return null;
}
val calendar = Calendar.getInstance
- "spark_streamload_" +
+ val labelPrefix = streamLoadProps.getOrElse("label_prefix",
"spark_streamload")
+ labelPrefix + "_" +
Review Comment:
> Would it be better to expose a parameter directly here, such as
doris.sink.label-prefix? Adding it directly to streamLoadProps may cause
confusion in the streamload header?
en, makes sense, has been modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
