github-actions[bot] commented on PR #42467:
URL: https://github.com/apache/doris/pull/42467#issuecomment-2436937408
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11512892999";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/fdb/fdb_ctl.sh line 84:
arch=`uname -m`
^--------^ SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
Did you mean:
arch=$(uname -m)
In tools/fdb/fdb_ctl.sh line 85:
if [ $arch == "x86_64" ]; then
^-------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests
in Bash/Ksh.
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "${arch}" == "x86_64" ]]; then
In tools/fdb/fdb_ctl.sh line 97:
elif [ $arch == "aarch64" ]; then
^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^---^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
elif [[ "${arch}" == "aarch64" ]]; then
In tools/fdb/fdb_ctl.sh line 110:
echo "Unsupported architecture: "$arch
^---^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^---^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
echo "Unsupported architecture: ""${arch}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of
le...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/fdb/fdb_ctl.sh.orig
+++ tools/fdb/fdb_ctl.sh
@@ -81,7 +81,7 @@
return
fi
- arch=`uname -m`
+ arch=$(uname -m)
if [ $arch == "x86_64" ]; then
local
URL="https://github.com/apple/foundationdb/releases/download/${FDB_VERSION}/";
local TMP="${FDB_PKG_DIR}-tmp"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
