github-actions[bot] commented on code in PR #42465:
URL: https://github.com/apache/doris/pull/42465#discussion_r1816017896
##########
be/src/agent/cgroup_cpu_ctl.h:
##########
@@ -48,18 +48,44 @@ class CgroupCpuCtl {
// for log
void get_cgroup_cpu_info(uint64_t* cpu_shares, int* cpu_hard_limit);
- virtual Status delete_unused_cgroup_path(std::set<uint64_t>& used_wg_ids)
= 0;
+ static void init_doris_cgroup_path();
-protected:
- Status write_cg_sys_file(std::string file_path, int value, std::string
msg, bool is_append);
+ static Status delete_unused_cgroup_path(std::set<uint64_t>& used_wg_ids);
+
+ static std::unique_ptr<CgroupCpuCtl> create_cgroup_cpu_ctl(uint64_t wg_id);
+
+ static bool is_a_valid_cgroup_path(std::string cg_path);
+ static uint64_t cpu_soft_limit_default_value();
+
+protected:
virtual Status modify_cg_cpu_hard_limit_no_lock(int cpu_hard_limit) = 0;
virtual Status modify_cg_cpu_soft_limit_no_lock(int cpu_shares) = 0;
- std::string _doris_cgroup_cpu_path;
- uint64_t _cpu_core_num = CpuInfo::num_cores();
- uint64_t _cpu_cfs_period_us = 100000;
+ Status add_thread_to_cgroup(std::string task_file);
+
+ static Status write_cg_sys_file(std::string file_path, std::string value,
std::string msg,
+ bool is_append);
+
+ static Status init_cgroup_v2_query_path_public_file(std::string home_path,
+ std::string
query_path);
+
+protected:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/agent/cgroup_cpu_ctl.h:60:** previously declared here
```cpp
protected:
^
```
</details>
##########
be/src/agent/cgroup_cpu_ctl.h:
##########
@@ -48,18 +48,44 @@
// for log
void get_cgroup_cpu_info(uint64_t* cpu_shares, int* cpu_hard_limit);
- virtual Status delete_unused_cgroup_path(std::set<uint64_t>& used_wg_ids)
= 0;
+ static void init_doris_cgroup_path();
-protected:
- Status write_cg_sys_file(std::string file_path, int value, std::string
msg, bool is_append);
+ static Status delete_unused_cgroup_path(std::set<uint64_t>& used_wg_ids);
+
+ static std::unique_ptr<CgroupCpuCtl> create_cgroup_cpu_ctl(uint64_t wg_id);
+
+ static bool is_a_valid_cgroup_path(std::string cg_path);
+ static uint64_t cpu_soft_limit_default_value();
+
+protected:
virtual Status modify_cg_cpu_hard_limit_no_lock(int cpu_hard_limit) = 0;
virtual Status modify_cg_cpu_soft_limit_no_lock(int cpu_shares) = 0;
- std::string _doris_cgroup_cpu_path;
- uint64_t _cpu_core_num = CpuInfo::num_cores();
- uint64_t _cpu_cfs_period_us = 100000;
+ Status add_thread_to_cgroup(std::string task_file);
+
+ static Status write_cg_sys_file(std::string file_path, std::string value,
std::string msg,
+ bool is_append);
+
+ static Status init_cgroup_v2_query_path_public_file(std::string home_path,
+ std::string
query_path);
+
+protected:
+ inline static uint64_t _cpu_core_num;
+ const static uint64_t _cpu_cfs_period_us = 100000;
+ inline static std::string _doris_cgroup_cpu_path = "";
+ inline static std::string _doris_cgroup_cpu_query_path = "";
+ inline static bool _is_enable_cgroup_v1_in_env = false;
+ inline static bool _is_enable_cgroup_v2_in_env = false;
+ inline static bool _is_cgroup_query_path_valid = false;
+
+ // cgroup v2 public file
+ inline static std::string _doris_cgroup_cpu_path_subtree_ctl_file = "";
+ inline static std::string _cgroup_v2_query_path_subtree_ctl_file = "";
+ inline static std::string _doris_cg_v2_procs_file = "";
+
+protected:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/agent/cgroup_cpu_ctl.h:60:** previously declared here
```cpp
protected:
^
```
</details>
##########
be/src/runtime/runtime_query_statistics_mgr.cpp:
##########
@@ -47,7 +47,7 @@ void
RuntimeQueryStatiticsMgr::register_query_statistics(std::string query_id,
_query_statistics_ctx_map.at(query_id)->_qs_list.push_back(qs_ptr);
}
-void RuntimeQueryStatiticsMgr::report_runtime_query_statistics() {
+void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
Review Comment:
warning: function 'report_runtime_query_statistics' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/runtime_query_statistics_mgr.cpp:49:** 117 lines including
whitespace and comments (threshold 80)
```cpp
void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
