github-actions[bot] commented on code in PR #42125:
URL: https://github.com/apache/doris/pull/42125#discussion_r1815187710
##########
be/src/olap/rowset/rowset.h:
##########
@@ -310,6 +310,10 @@ class Rowset : public std::enable_shared_from_this<Rowset>
{
Result<std::string> segment_path(int64_t seg_id);
+ Result<std::string> rowset_dir();
+
+ virtual Result<std::vector<io::FileInfo>> list_inverted_index_files() = 0;
+
protected:
Review Comment:
warning: prefer deleting copy constructor and assignment operator over using
macro 'DISALLOW_COPY_AND_ASSIGN'
[modernize-replace-disallow-copy-and-assign-macro]
```suggestion
y;
t);Rowset(const Rowset &) = delete;
const Rowset &operator=(const Rowset &) = delete
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
