gavinchou commented on code in PR #42043:
URL: https://github.com/apache/doris/pull/42043#discussion_r1814770560
##########
cloud/src/meta-service/txn_lazy_committer.cpp:
##########
@@ -303,31 +303,33 @@ void TxnLazyCommitTask::commit() {
code_ = MetaServiceCode::OK;
msg_.clear();
int64_t db_id;
- std::vector<std::pair<std::string, doris::RowsetMetaCloudPB>>
tmp_rowset_metas;
- scan_tmp_rowset(instance_id_, txn_id_, txn_kv_, code_, msg_,
&db_id, &tmp_rowset_metas);
+ std::vector<std::pair<std::string, doris::RowsetMetaCloudPB>>
all_tmp_rowset_metas;
+ scan_tmp_rowset(instance_id_, txn_id_, txn_kv_, code_, msg_,
&db_id,
+ &all_tmp_rowset_metas);
if (code_ != MetaServiceCode::OK) {
LOG(WARNING) << "scan_tmp_rowset failed, txn_id=" << txn_id_
<< " code=" << code_;
break;
}
VLOG_DEBUG << "txn_id=" << txn_id_
- << " tmp_rowset_metas.size()=" <<
tmp_rowset_metas.size();
- if (tmp_rowset_metas.size() == 0) {
+ << " tmp_rowset_metas.size()=" <<
all_tmp_rowset_metas.size();
+ if (all_tmp_rowset_metas.size() == 0) {
LOG(INFO) << "empty tmp_rowset_metas, txn_id=" << txn_id_;
}
// <partition_id, tmp_rowsets>
std::unordered_map<int64_t,
std::vector<std::pair<std::string,
doris::RowsetMetaCloudPB>>>
partition_to_tmp_rowset_metas;
- for (auto& [tmp_rowset_key, tmp_rowset_pb] : tmp_rowset_metas) {
+ for (auto& [tmp_rowset_key, tmp_rowset_pb] : all_tmp_rowset_metas)
{
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].emplace_back();
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].back().first =
tmp_rowset_key;
partition_to_tmp_rowset_metas[tmp_rowset_pb.partition_id()].back().second =
tmp_rowset_pb;
}
+ int64_t table_id = -1;
Review Comment:
one-stream-multi-table load?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
