zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1814348216
##########
be/src/common/elf.cpp:
##########
@@ -40,21 +41,22 @@ Elf::Elf(const std::string& path) {
std::error_code ec;
elf_size = std::filesystem::file_size(_file, ec);
if (ec) {
- LOG(FATAL) << fmt::format("failed to get file size {}: ({}), {}",
_file.native(),
- ec.value(), ec.message());
+ throw Exception(Status::IOError("failed to get file size {}: ({}),
{}", _file.native(),
Review Comment:
please add a new error type. we can call it `FatalError`. and for all
Exception changed from `LOG(FATAL)`, use it as the error code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
