gavinchou commented on code in PR #41818:
URL: https://github.com/apache/doris/pull/41818#discussion_r1814344111
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -1302,8 +1347,18 @@ void BlockFileCache::remove(FileBlockSPtr file_block, T&
cache_lock, U& block_lo
*_num_removed_blocks << 1;
}
+void BlockFileCache::recycle_stale_rowset_async_bottom_half() {
+ FileCacheKey key;
+ while (_recycle_keys->pop(key)) {
+ Status st = _storage->remove(key);
+ if (!st.ok()) {
+ LOG_WARNING("").error(st);
Review Comment:
put some key word in the log e.g.
"failed to remove when recycle_stale_rowset_async_bottom_half, key = {}" ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
