morningman opened a new issue, #9267:
URL: https://github.com/apache/incubator-doris/issues/9267

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   1.0.0
   
   ### What's Wrong?
   
   the -214 error code means "some version of this replica is missing".
   In #8209, I modified some logic to handle -214, but one logic is wrong, that 
is:
   
   1. When BE report that one tablet is missing version, the FE will set 
replica's last failed version to 1:
   
   
https://github.com/apache/incubator-doris/blob/26bc462e1c46dd751de15d3b477d59015a948476/fe/fe-core/src/main/java/org/apache/doris/master/ReportHandler.java#L829-L837
   
   But this is wrong, because the replica's last failed version should always 
larger than replica's version, otherwise,
   it will be rectified when calling updateReplicaInfo():
   
   
https://github.com/apache/incubator-doris/blob/26bc462e1c46dd751de15d3b477d59015a948476/fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java#L348-L357
   
   ### What You Expected?
   
   the tablet report logic is valid.
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to