morningman commented on code in PR #42253:
URL: https://github.com/apache/doris/pull/42253#discussion_r1810359603
##########
fe/fe-core/src/main/java/org/apache/doris/job/manager/TaskDisruptorGroupManager.java:
##########
@@ -65,8 +65,10 @@ public class TaskDisruptorGroupManager<T extends
AbstractTask> {
private static final int DISPATCH_MTMV_THREAD_NUM =
Config.job_mtmv_task_consumer_thread_num > 0
? Config.job_mtmv_task_consumer_thread_num :
DEFAULT_CONSUMER_THREAD_NUM;
- private static final int DISPATCH_INSERT_TASK_QUEUE_SIZE =
DEFAULT_RING_BUFFER_SIZE;
- private static final int DISPATCH_MTMV_TASK_QUEUE_SIZE =
DEFAULT_RING_BUFFER_SIZE;
+ private static final int DISPATCH_INSERT_TASK_QUEUE_SIZE =
isPowerOfTwo(Config.insert_task_queue_size)
Review Comment:
Do not check `isPowerOfTwo` here
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1776,6 +1776,12 @@ public class Config extends ConfigBase {
"Maximum number of persistence allowed per task in a job,exceeding
which old tasks will be discarded，"
+ "If the value is less than 1, it will not be persisted."
})
public static int max_persistence_task_count = 100;
+ @ConfField(description = {"MV task 的等待队列大小，值必须是 2 的幂，否则将使用默认值 1024", "The
size of the MV task's"
Review Comment:
use `setter` to check if value is power of 2.
And you can also check if the value is too large or too small.
And need to test unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
