HappenLee commented on code in PR #41968:
URL: https://github.com/apache/doris/pull/41968#discussion_r1808421399


##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -313,12 +182,54 @@ class PipChannel final : public 
Channel<pipeline::ExchangeSinkLocalState> {
 
     std::shared_ptr<pipeline::Dependency> get_local_channel_dependency();
 
-private:
+protected:
+    Status _send_local_block(bool eos);
+    Status _send_current_block(bool eos);
+
+    bool _recvr_is_valid() {

Review Comment:
   should we return Status in this func and dispose the `_receiver_status` out 
the function is better ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to