yiguolei commented on code in PR #9226: URL: https://github.com/apache/incubator-doris/pull/9226#discussion_r858506680
########## be/src/vec/common/hash_table/hash_table.h: ########## @@ -245,11 +245,14 @@ struct HashTableGrower { /// The state of this structure is enough to get the buffer size of the hash table. doris::vectorized::UInt8 size_degree = initial_size_degree; + size_t _buf_size = 1ULL << initial_size_degree; + size_t _max_fill = 1ULL << (initial_size_degree - 1); Review Comment: I think we'd better not change this. I find that it only improved about 0.02%. But the readability of the code is affected. Maybe @HappenLee could read this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org