(doris) branch branch-2.1 updated: [Fix](orc-reader) Fix StringRef nullptr data by add checking string_values empty. #42061 (#42154)

[morningman]

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new b9e2738ee68 [Fix](orc-reader) Fix StringRef nullptr data by add 
checking string_values empty. #42061 (#42154)
b9e2738ee68 is described below

commit b9e2738ee68b9d30c594bee188e5f566d3cc3155
Author: Rayner Chen <morning...@163.com>
AuthorDate: Mon Oct 21 16:26:23 2024 +0800

    [Fix](orc-reader) Fix StringRef nullptr data by add checking string_values 
empty. #42061 (#42154)
    
    cherry pick from #42061
    
    Co-authored-by: Qi Chen <kaka11.c...@gmail.com>
---
 be/src/vec/exec/format/orc/vorc_reader.cpp | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/be/src/vec/exec/format/orc/vorc_reader.cpp 
b/be/src/vec/exec/format/orc/vorc_reader.cpp
index d564ea0effc..cda24f4990f 100644
--- a/be/src/vec/exec/format/orc/vorc_reader.cpp
+++ b/be/src/vec/exec/format/orc/vorc_reader.cpp
@@ -1175,7 +1175,9 @@ Status 
OrcReader::_decode_string_non_dict_encoded_column(const std::string& col_
             }
         }
     }
-    data_column->insert_many_strings(&string_values[0], num_values);
+    if (!string_values.empty()) {
+        data_column->insert_many_strings(&string_values[0], num_values);
+    }
     return Status::OK();
 }
 
@@ -1279,8 +1281,10 @@ Status 
OrcReader::_decode_string_dict_encoded_column(const std::string& col_name
             }
         }
     }
-    data_column->insert_many_strings_overflow(&string_values[0], 
string_values.size(),
-                                              max_value_length);
+    if (!string_values.empty()) {
+        data_column->insert_many_strings_overflow(&string_values[0], 
string_values.size(),
+                                                  max_value_length);
+    }
     return Status::OK();
 }
 
@@ -2394,7 +2398,9 @@ MutableColumnPtr 
OrcReader::_convert_dict_column_to_string_column(
             }
         }
     }
-    res->insert_many_strings_overflow(&string_values[0], num_values, 
max_value_length);
+    if (!string_values.empty()) {
+        res->insert_many_strings_overflow(&string_values[0], num_values, 
max_value_length);
+    }
     return res;
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org