[GitHub] [incubator-doris] morningman commented on a diff in pull request #9151: Support hive with HA HDFS. Pass ha configuration through hive create table properties.

[GitBox]

morningman commented on code in PR #9151:
URL: https://github.com/apache/incubator-doris/pull/9151#discussion_r858270515


##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -522,7 +528,11 @@ private void processFileGroup(
                     
rangeDesc.setNumAsString(context.fileGroup.isNumAsString());
                     
rangeDesc.setReadJsonByLine(context.fileGroup.isReadJsonByLine());
                 }
-                rangeDesc.setHdfsParams(tHdfsParams);
+                if (rangeDesc.hdfs_params != null && 
rangeDesc.hdfs_params.getFsName() == null)
+                    rangeDesc.hdfs_params.setFsName(fsName);
+                else if (rangeDesc.hdfs_params == null)

Review Comment:
   Use {} with if else



##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -499,7 +501,11 @@ private void processFileGroup(
                 } else {
                     TBrokerRangeDesc rangeDesc = 
createBrokerRangeDesc(curFileOffset, fileStatus, formatType,
                             leftBytes, columnsFromPath, 
numberOfColumnsFromFile, brokerDesc, header_type);
-                    rangeDesc.setHdfsParams(tHdfsParams);
+                    if (rangeDesc.hdfs_params != null && 
rangeDesc.hdfs_params.getFsName() == null)
+                        rangeDesc.hdfs_params.setFsName(fsName);
+                    else if (rangeDesc.hdfs_params == null)

Review Comment:
   use {} with if else block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org